Add label clone command - #5452
Conversation
|
I could do that as well. The funcs would have to be public, of course, but all that is under internal/ anyway. |
|
@samcoe wanted to get your preliminary feedback on this. Once I incorporate any feedback I will add tests and convert this to a real PR. |
samcoe
left a comment
There was a problem hiding this comment.
@heaths Appreciate the hard work here. This looks great, thanks for the thorough tests. I pushed a small commit to polish up a couple tiny things rather than going through another round of review. I will get this merged before the next release.
|
Some thoughts for future improvements that we might want to address after testing out the command:
I don't think either needs to be addressed right away just food for thought. |
@samcoe, anything holding it up now? I have another PR that is based on this work to improve the
I've never actually tested this nor seen it in docs, but is there a simultaneous connection limit per client ID for GitHub APIs? And, if so, is it different for REST vs. GraphQL? This could significantly impact the design. Could either go with a fixed-sized goroutine pool or just span goroutines as needed e.g. per label creation/update. Normally I'd lean toward the former. |
Keeps shared functions privage to the package while sharing with all label commands.
|
Rebased on trunk to resolve merge conflicts. |
|
Documented in https://cli.github.com/manual/gh_label_clone It helps on community/community#15300 |
|
🎁 Thanks a lot for the feature 🙏 |
Resolves #5441