Skip to content

Allow forcibly creating labels - #5451

Merged
samcoe merged 3 commits into
cli:trunkfrom
heaths:issue5450
Apr 14, 2022
Merged

Allow forcibly creating labels#5451
samcoe merged 3 commits into
cli:trunkfrom
heaths:issue5450

Conversation

@heaths

@heaths heaths commented Apr 13, 2022

Copy link
Copy Markdown
Contributor

Resolves #5450

@heaths
heaths requested a review from a team as a code owner April 13, 2022 05:49
@heaths
heaths requested review from samcoe and removed request for a team April 13, 2022 05:49
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Apr 13, 2022
@heaths heaths mentioned this pull request Apr 13, 2022

@samcoe samcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heaths Overall the code looks great, I left one comment regarding correct detection of fail cases that we should address.

Comment thread pkg/cmd/label/create/create.go Outdated
@samcoe samcoe self-assigned this Apr 13, 2022

@samcoe samcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes, I think this is good to go! I made a small change to 💅 the output a bit 🙇

@samcoe
samcoe enabled auto-merge (squash) April 14, 2022 07:22
@samcoe
samcoe merged commit 1b7d03f into cli:trunk Apr 14, 2022
@heaths
heaths deleted the issue5450 branch April 14, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow gh label create to forcibly create existing labels

3 participants