Skip to content

[Settings] Truncate long startup URLs on the Get started page - #39829

Merged
simonhong merged 1 commit into
masterfrom
fix_long_startup_url_ellipsis
Sep 14, 2026
Merged

[Settings] Truncate long startup URLs on the Get started page#39829
simonhong merged 1 commit into
masterfrom
fix_long_startup_url_ellipsis

Conversation

@simonhong

@simonhong simonhong commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Brave re-hosts settings-on-startup-page inside a .settings-box, which is a
flex container, so the element's default min-width: auto floored it at the
min-content width of the longest startup URL. The URL never elided and the
edit/remove button was clipped out of the card.

Add no-min-width (min-width: 0) so the element can shrink below its content
width, and flex so it still spans the full row.

image

@simonhong simonhong self-assigned this Sep 14, 2026
@simonhong
simonhong marked this pull request as ready for review September 14, 2026 06:12
fallaciousreasoning
fallaciousreasoning approved these changes Sep 14, 2026
View reviewed changes

@fallaciousreasoning fallaciousreasoning left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we normally truncate origins from the middle. If this matches Chromium, this is all good, but if not we might need to do some funkiness

i.e.

https://google.com.evil.com/foo/bar should truncate to

...om.evil.com/...

@simonhong

simonhong commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

lgtm, but we normally truncate origins from the middle. If this matches Chromium, this is all good, but if not we might need to do some funkiness

i.e.

https://google.com.evil.com/foo/bar should truncate to

...om.evil.com/...

Thanks for review! It's upstream's behavior.
image

@simonhong
simonhong merged commit 569e7f1 into master Sep 14, 2026
20 checks passed
@simonhong
simonhong deleted the fix_long_startup_url_ellipsis branch September 14, 2026 06:48
@brave-builds brave-builds added this to the 1.97.x - Nightly milestone Sep 14, 2026
@brave-builds

brave-builds commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Released in v1.97.31

@brave-builds brave-builds mentioned this pull request Sep 16, 2026
Merged
4 of 7 tasks
@kjozwiak

kjozwiak commented Sep 19, 2026

Copy link
Copy Markdown
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.98.11 Chromium: 154.0.8037.49 (Official Build) nightly (64-bit)
-- | --
Revision | 0fe28a02ed9983e61ade571463941936b69d699a
OS | Windows 11 Version 25H2 (Build 26200.9278)

Using the STR/Cases outlined via brave/brave-browser#58846 (comment), ensured that the Hamburger Menu/Kabob doesn't get cut off when there's long URLs under Open a specific page or set of pages via brave://settings/getStarted as per the following:

  • ensured that both Edit & Remove work as expected as well
image

kjozwiak pushed a commit that referenced this pull request Sep 19, 2026
@brave-builds
[Settings] Truncate long startup URLs on the Get started page (uplift…
5c01b86 
… to 1.96.x) (#39914)

Uplift of #39829 (squashed) to beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

Assignees

@simonhong simonhong

Labels

None yet

Projects

None yet

Milestone

1.97.x - Release

Development

Successfully merging this pull request may close these issues.

Startup pages can't be edited/removed

4 participants

@simonhong @brave-builds @kjozwiak @fallaciousreasoning