[Android] Source URL bar icons from Nala - #39552
Merged
Merged
Conversation
SergeyZhukovsky
requested review from
aguscruiz,
cdesouza-chromium,
chrislacy and
samartnik
September 1, 2026 19:01
Contributor
📋 Code Owners Summary5 file(s) changed, 1 with assigned owners 1 team(s) affected: Owners and Their Files
|
Contributor
|
Chromium major version is behind target branch (152.0.7977.64 vs 153.0.8010.18). Please rebase. |
SergeyZhukovsky
force-pushed
the
android_url_bar_nala_icons
branch
from
September 1, 2026 22:00
a4134c6 to
fc5ece9
Compare
netzenbot
approved these changes
Sep 2, 2026
Replace the hand-authored QR and picture-in-picture drawables and the btn_brave/btn_brave_off/btn_bat density PNGs with Nala equivalents mirrored through android/nala. Icons keep Nala's native 24dp. Resolves: brave/brave-browser#46059
The wallet icon was tinted pure white on dark toolbars and the PiP icon was never tinted at all, so both stood out against the status icon next to them. Tint the two from ThemeUtils, which is what the status icon and the QR and mic buttons already use.
SergeyZhukovsky
force-pushed
the
android_url_bar_nala_icons
branch
from
September 2, 2026 14:08
fc5ece9 to
7ee1590
Compare
Member
Author
|
@aguscruiz in a DM pointed me that there are 2 problems: a wallet icon tinted pure white on dark theme and PiP icon was never tinted at all. Fixed it and there are updated screenshots |
aguscruiz
approved these changes
Sep 2, 2026
aguscruiz
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thanks for the fix!
Collaborator
|
Released in v1.96.41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-authored QR and picture-in-picture drawables and the btn_brave/btn_brave_off/btn_bat density PNGs with Nala equivalents mirrored through android/nala. Icons keep Nala's native 24dp.
Resolves: brave/brave-browser#46059