Skip to content

Add comment role #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnurthen merged 19 commits into from
Feb 11, 2020
Merged

Add comment role #1135

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d20851c
Add comment role
Dec 11, 2019
7eef5ed
Improvements
Jan 14, 2020
59a1cbf
Keep empty td on one line
Jan 15, 2020
306929d
Better wording
Jan 15, 2020
4203687
Update index.html
aleventhal Jan 15, 2020
559e9a7
Update index.html
aleventhal Jan 15, 2020
46a3354
Update index.html
aleventhal Jan 15, 2020
52bb688
Update index.html
aleventhal Jan 15, 2020
c65afd8
Slight improvement to ancestor language
Jan 16, 2020
415c17c
Update inheritance, name, supported properties
Jan 16, 2020
d29a1e7
Remove prohibited aria-label* properties
Jan 16, 2020
eb690b9
Update index.html
aleventhal Jan 27, 2020
4a484cb
Less restrictive summary
Jan 27, 2020
bbadb71
Reworded, inspired by mck
Jan 27, 2020
4e735be
Update index.html
aleventhal Jan 28, 2020
157e90d
Update index.html
aleventhal Jan 28, 2020
6ed859a
Use group or region for comment container
Jan 30, 2020
2ad3609
Turn group/region role request for comment container into a SHOULD
Jan 30, 2020
75a6436
Update index.html
aleventhal Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update index.html 
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
  • Loading branch information
@aleventhal @carmacleod Aaron Leventhal
2 people authored and Aaron Leventhal committed Feb 7, 2020
commit 559e9a786daa722b2c113932a9909bbfeb1d1af8
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2332,7 +2332,7 @@ <h2>Definition of Roles</h2>
<rdef>comment</rdef>
<div class="role-description">
<p>A comment contains a remark expressing a reaction to other content within the page.</p>
Comment thread
aleventhal marked this conversation as resolved.
Outdated
<p>The relationship of comments to other content SHOULD be exposed:</p>
<p>The relationship of comments to other content SHOULD be exposed as follows:</p>
Comment thread
aleventhal marked this conversation as resolved.
Outdated
<ol>
<li>When the comment refers to other content within the page, the source content SHOULD use <pref>aria-details</pref> to point to the related comment.</li>
Comment thread
aleventhal marked this conversation as resolved.
Outdated
<li>When the comment is a reply to another comment:
Comment thread
aleventhal marked this conversation as resolved.
Outdated
Expand Down