Fix extend account console content routes - #52600
Open
daanbreur wants to merge 2 commits into
Open
Conversation
Signed-off-by: Daan Breur <git@daanbreur.systems>
Signed-off-by: Daan Breur <git@daanbreur.systems>
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Fixes extending the Account Console via content routes by preventing custom content menu items from being converted into exact routes and ensuring the generic content route is registered so custom components resolve correctly.
Changes:
- Skip generating exact
RouteObjects for menu items backed bymodulePathso they don’t shadow the generic content route. - Register
ContentRoutein the router children to handlecontent/:componentId. - Improve recursive resolution of custom content modules and force remount on module changes in
ContentComponent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| js/apps/account-ui/src/root/Root.tsx | Avoids mapping custom module-backed menu items to exact routes and adds the generic content route to router configuration. |
| js/apps/account-ui/src/content/ContentComponent.tsx | Fixes recursive module resolution and remounts dynamically-loaded content when the resolved module changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ); | ||
|
|
||
| return modulePath && <Component modulePath={modulePath} />; | ||
| return modulePath && <Component key={modulePath} modulePath={modulePath} />; |
| // Custom content is rendered by ContentRoute. Adding an exact route for | ||
| // every custom item here would shadow the generic content/:componentId | ||
| // route with an element that cannot be resolved from the built-in routes. | ||
| if (item.modulePath) { |
| import { Header } from "./Header"; | ||
| import { MenuItem, PageNav } from "./PageNav"; | ||
| import { routes } from "../routes"; | ||
| import { ContentRoute, routes } from "../routes"; |
| errorElement: <ErrorPage />, | ||
| children: [ | ||
| ...mapRoutes(context, content), | ||
| ContentRoute, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the extending of the account console using the content routes.
Closes #41433 and keycloak/keycloak-quickstarts#678