Fixed Skill Loader function - #29225
Conversation
Co-authored-by: Diyor-Khasanov-dev <317548684+Diyor-Khasanov-dev@users.noreply.github.com>
…atter-trailing-spaces-997008907762288301 fix(core): allow trailing spaces on SKILL.md frontmatter delimiters
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the skill loader by updating the regular expression used to parse frontmatter. By allowing optional whitespace characters after the delimiter markers, the system becomes more resilient to minor formatting inconsistencies in skill definition files. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the FRONTMATTER_REGEX in packages/core/src/skills/skillLoader.ts to allow trailing spaces and tabs after the frontmatter delimiters (---) and adds an end-of-string anchor ($). It also adds a corresponding unit test in packages/core/src/skills/skillLoader.test.ts to verify parsing of skills with trailing spaces in frontmatter delimiters. There are no review comments, and I have no feedback to provide.
Summary
Details
Related Issues
How to Validate
Pre-Merge Checklist