Skip to content

fix: repair missing action rows on status update - #7812

Open
Rohithmatham12 wants to merge 1 commit into
flyteorg:mainfrom
Rohithmatham12:codex/flyte-self-heal-missing-action-status
Open

fix: repair missing action rows on status update#7812
Rohithmatham12 wants to merge 1 commit into
flyteorg:mainfrom
Rohithmatham12:codex/flyte-self-heal-missing-action-status

Conversation

@Rohithmatham12

Copy link
Copy Markdown
Contributor

Summary

  • return a repository-level ErrActionNotFound when UpdateActionPhase matches no row and the action truly does not exist
  • map that sentinel to a NotFound status in InternalRunService.UpdateActionStatus
  • make the actions watcher re-record the TaskAction and retry UpdateActionStatus when the run service reports NotFound
  • preserve stale/backward phase no-op behavior by checking row existence before returning NotFound

Fixes #7257.

Testing

  • GOCACHE=/private/tmp/flyte-go-cache GOMODCACHE=/private/tmp/flyte-go-mod-cache go test ./actions/k8s -run 'TestNotifyRunService_RecordAndRetryWhenStatusUpdateReturnsNotFound$'\n- GOCACHE=/private/tmp/flyte-go-cache GOMODCACHE=/private/tmp/flyte-go-mod-cache go test ./runs/service -run 'TestUpdateActionStatus_MissingActionReturnsNotFoundStatus$'\n- GOCACHE=/private/tmp/flyte-go-cache GOMODCACHE=/private/tmp/flyte-go-mod-cache go test ./runs/repository/impl -run 'TestUpdateActionPhase_(MissingActionReturnsNotFound|BlocksBackwardFromSucceeded)$'

@github-actions github-actions Bot added the flyte2 label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InternalRunService: silent data loss when RecordAction fails before UpdateActionStatus

1 participant