[Android] Migrate 3-dot menu icons to Nala - #39309
Merged
Merged
Conversation
Swaps the app menu, its icon row and the tab switcher menu over to Leo icons per the mapping agreed with design, and normalises the sizes the issue asks about: the pin (a 20dp glyph scaled inside a 24dp box), Shred (20dp) and Open with (18dp) all become 24dp Leo vectors, matching the settings page. Upstream-owned drawables are replaced through icons.gni, so most rows need no call site change. Drawables that chrome/android/java/res owns need a second overlay target that depends on chrome_app_java_resources: that target sets resource_overlay on its own sources, so it beats any overlay it merely depends on. PNG-only icons rasterise into the same target, and ic_refresh_24dp_rtl is generated by mirroring the Nala source rather than hand-copied. Brave-owned drawables are repointed at Leo icons and deleted, along with the hand-copies the overrides replace and their update_patches_exclusions.cfg entries. Resolves: brave/brave-browser#56196
aguscruiz
approved these changes
Aug 21, 2026
aguscruiz
left a comment
Collaborator
There was a problem hiding this comment.
They look great, thanks!
netzenbot
approved these changes
Aug 22, 2026
Collaborator
|
Released in v1.96.9 |
r0hit0303
pushed a commit
that referenced
this pull request
Aug 28, 2026
Swaps the app menu, its icon row and the tab switcher menu over to Leo icons per the mapping agreed with design, and normalises the sizes the issue asks about: the pin (a 20dp glyph scaled inside a 24dp box), Shred (20dp) and Open with (18dp) all become 24dp Leo vectors, matching the settings page. Upstream-owned drawables are replaced through icons.gni, so most rows need no call site change. Drawables that chrome/android/java/res owns need a second overlay target that depends on chrome_app_java_resources: that target sets resource_overlay on its own sources, so it beats any overlay it merely depends on. PNG-only icons rasterise into the same target, and ic_refresh_24dp_rtl is generated by mirroring the Nala source rather than hand-copied. Brave-owned drawables are repointed at Leo icons and deleted, along with the hand-copies the overrides replace and their update_patches_exclusions.cfg entries. Resolves: brave/brave-browser#56196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swaps the app menu, its icon row and the tab switcher menu over to Leo icons per the mapping agreed with design, and normalises the sizes the issue asks about: the pin (a 20dp glyph scaled inside a 24dp box), Shred (20dp) and Open with (18dp) all become 24dp Leo vectors, matching the settings page.
Upstream-owned drawables are replaced through icons.gni, so most rows need no call site change. Drawables that chrome/android/java/res owns need a second overlay target that depends on chrome_app_java_resources: that target sets resource_overlay on its own sources, so it beats any overlay it merely depends on. PNG-only icons rasterise into the same target, and ic_refresh_24dp_rtl is generated by mirroring the Nala source rather than hand-copied.
Brave-owned drawables are repointed at Leo icons and deleted, along with the hand-copies the overrides replace and their update_patches_exclusions.cfg entries.
Resolves: brave/brave-browser#56196
Phone:
Tablet: