Skip to content

[iOS] Promote QuickView to a regular tab on navigation failure - #40415

Open
nuo-xu wants to merge 2 commits into
masterfrom
quickview/ssl-error
Open

nuo-xu wants to merge 2 commits into
masterfrom
quickview/ssl-error

Conversation

@nuo-xu

@nuo-xu nuo-xu commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Promote failing URL to a regular tab, ignoring cancellations from our policy deciders and pending HTTPS upgrades so interstitial-driven cancels don't trigger a spurious promotion.

NOTE: if #40413 has not yet merged, you will experience a DCHECK crash on a debug build. You will need to cherry-pick this commit in order to verify this PR.

  • Resolves

Test:

  1. enable QV feature flag via brave://flags
  2. modify via web inspetor or make Ask Brave gives you the link of https://samesitetest.com
  3. click this link
  4. verify QV will be brought up but soon it will be dismissed and a new regular tab with this link is loaded and in this case, you will see an error page in this regular tab.

@nuo-xu
nuo-xu requested review from a team and kdenhartog October 1, 2026 10:48
@nuo-xu nuo-xu self-assigned this Oct 1, 2026
@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin labels Oct 1, 2026
Comment thread ios/brave-ios/Sources/Brave/Frontend/Browser/QuickView/QuickViewController.swift Outdated
@nuo-xu
nuo-xu force-pushed the quickview/ssl-error branch from 912d5e3 to db39d40 Compare October 1, 2026 17:40
@nuo-xu
nuo-xu force-pushed the quickview/ssl-error branch from db39d40 to d00d2bb Compare October 2, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-origin Do not run CI builds for Origin CI/skip-windows-x64 Do not run CI builds for Windows x64

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants