Conversation
Contributor
📋 Code Owners Summary9 file(s) changed, 5 with assigned owners 1 team(s) affected: Owners and Their Files
|
goodov
force-pushed
the
jest-ts-import-meta-transform
branch
from
September 24, 2026 18:34
bec2224 to
412b8b8
Compare
Collaborator
|
A Storybook has been deployed to preview UI for the latest push |
goodov
force-pushed
the
jest-ts-import-meta-transform
branch
from
September 25, 2026 06:01
412b8b8 to
83d896b
Compare
goodov
marked this pull request as ready for review
September 25, 2026 08:04
bbondy
previously approved these changes
Sep 25, 2026
bbondy
dismissed
their stale review
September 25, 2026 23:53
Approval was posted from the wrong account.
netzenbot
approved these changes
Sep 25, 2026
Contributor
|
Chromium major version is behind target branch (154.0.8037.58 vs 155.0.8059.16). Please rebase. |
fallaciousreasoning
approved these changes
Sep 27, 2026
atuchin-m
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
import.meta.*to be used freely inbuild/commandsand other parts of the codebase by rewriting to matching CommonJS idioms. This allows Jest to properly handle those statements in imported files.The right way to support
import.meta.*in Jest is by enabling--experimental-vm-moduleswhen running tests, but I'm not that confident we should go this path now, this flag is still experimental even in Node 26 and might introduce another layer of problems that we don't really want to deal with.