Skip to content

Fix: address possible nil panics #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bioball merged 1 commit into from
Feb 6, 2024
Merged

Fix: address possible nil panics #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkl/evaluator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ func (e *evaluator) handleReadResource(msg *msgapi.ReadResource) {
if err != nil {
response.Error = fmt.Errorf("internal error: failed to parse resource url: %w", err).Error()
e.manager.impl.outChan() <- response
return
}
var reader ResourceReader
for _, r := range e.resourceReaders {
Expand Down Expand Up @@ -199,6 +200,7 @@ func (e *evaluator) handleReadModule(msg *msgapi.ReadModule) {
if err != nil {
response.Error = fmt.Errorf("internal error: failed to parse resource url: %w", err).Error()
e.manager.impl.outChan() <- response
return
}
var reader ModuleReader
for _, r := range e.moduleReaders {
Expand All @@ -225,6 +227,7 @@ func (e *evaluator) handleListResources(msg *msgapi.ListResources) {
if err != nil {
response.Error = fmt.Errorf("internal error: failed to parse resource url: %w", err).Error()
e.manager.impl.outChan() <- response
return
}
var reader ResourceReader
for _, r := range e.resourceReaders {
Expand Down Expand Up @@ -258,6 +261,7 @@ func (e *evaluator) handleListModules(msg *msgapi.ListModules) {
if err != nil {
response.Error = fmt.Errorf("internal error: failed to parse resource url: %w", err).Error()
e.manager.impl.outChan() <- response
return
}
var reader ModuleReader
for _, r := range e.moduleReaders {
Expand Down