Dismiss viewed TUI warnings when closing the viewer - #48205
Merged
copyberry[bot] merged 1 commit intoSep 25, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Closing the warnings viewer left reviewed diagnostics in the warning badge and subsequent visits, with no way to dismiss them. ## What changed - Dismiss only warning pages actually rendered when closing with `Esc`, `F2`, or `Ctrl+C`, and update the footer hint to “dismiss & close”. Unviewed warnings remain available. - Hide dismissed diagnostics from the badge and viewer while their details are unchanged. Updated details make a warning visible again. - Reset dismissals when clearing the transcript and ignore queued dismissals from an earlier transcript. - Cache warning counts until transcript cell identities or dismissal decisions change. ## Testing Add regression coverage for partial dismissal, navigation that skips rendering a page, changed warning details, and transcript resets with queued dismissals. Update snapshots for the close hint and remaining warning count. GitOrigin-RevId: 3ce88c62a7f0ff9de34062165051e22168d3db25
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/3ce88c62a7f0ff9de34062165051e22168d3db25
branch
from
September 25, 2026 20:26
fe377bf to
7703f8b
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/3ce88c62a7f0ff9de34062165051e22168d3db25
branch
September 25, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dismiss viewed TUI warnings when closing the viewer
Why
Closing the warnings viewer left reviewed diagnostics in the warning badge and subsequent visits, with no way to dismiss them.
What changed
Esc,F2, orCtrl+C, and update the footer hint to “dismiss & close”. Unviewed warnings remain available.Testing
Add regression coverage for partial dismissal, navigation that skips rendering a page, changed warning details, and transcript resets with queued dismissals. Update snapshots for the close hint and remaining warning count.