Skip to content

Deduplicate retained instructions across Guardian reviews - #48060

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e90fca16cde0a0970da36dd873af2ca1dbaaf4d3
Sep 25, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e90fca16cde0a0970da36dd873af2ca1dbaaf4d3

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Deduplicate retained instructions across Guardian reviews

Why

Reused Guardian sessions already contain previously delivered instructions. Follow-up reviews can avoid repeating that evidence, but must deliver it again if it changes or compaction removes it.

What changed

  • Track retained source identity, revision, and completeness in host-owned history metadata, preserving revisions during replay.
  • Omit retained instructions from synchronous review inputs only when the same complete revision remains in reviewer history.
  • Restore missing evidence after reviewer compaction, enforcing the request budget before persisting additions. Classify restored evidence as context rather than new user authorization.
  • Keep source-order labels stable across eviction and retain full delivery for legacy records without reliable provenance.

Testing

Add coverage for consecutive-review deduplication, changed revisions, missing or incomplete metadata, and restoring compacted evidence exactly once. Extend compaction and resume coverage to verify retained revisions.

## Why

Reused Guardian sessions already contain previously delivered instructions. Follow-up reviews can avoid repeating that evidence, but must deliver it again if it changes or compaction removes it.

## What changed

- Track retained source identity, revision, and completeness in host-owned history metadata, preserving revisions during replay.
- Omit retained instructions from synchronous review inputs only when the same complete revision remains in reviewer history.
- Restore missing evidence after reviewer compaction, enforcing the request budget before persisting additions. Classify restored evidence as context rather than new user authorization.
- Keep source-order labels stable across eviction and retain full delivery for legacy records without reliable provenance.

## Testing

Add coverage for consecutive-review deduplication, changed revisions, missing or incomplete metadata, and restoring compacted evidence exactly once. Extend compaction and resume coverage to verify retained revisions.

GitOrigin-RevId: e90fca16cde0a0970da36dd873af2ca1dbaaf4d3
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e90fca16cde0a0970da36dd873af2ca1dbaaf4d3 branch from d1ae7b7 to 86be532 Compare September 25, 2026 10:50
@copyberry
copyberry Bot merged commit 86be532 into main Sep 25, 2026
14 of 18 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e90fca16cde0a0970da36dd873af2ca1dbaaf4d3 branch September 25, 2026 10:50
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2026
@SRNissen
SRNissen deployed to issue-triage September 25, 2026 11:03 — with GitHub Actions Active
@SRNissen
SRNissen deployed to issue-triage September 25, 2026 11:03 — with GitHub Actions Active
@SRNissen
SRNissen deployed to issue-triage September 25, 2026 11:03 — with GitHub Actions Active
@SRNissen
SRNissen deployed to issue-triage September 25, 2026 11:04 — with GitHub Actions Active
@BridgeAR
BridgeAR deployed to issue-triage September 25, 2026 11:10 — with GitHub Actions Active
@BridgeAR
BridgeAR deployed to issue-triage September 25, 2026 11:10 — with GitHub Actions Active
@BridgeAR
BridgeAR deployed to issue-triage September 25, 2026 11:10 — with GitHub Actions Active
@BridgeAR
BridgeAR deployed to issue-triage September 25, 2026 11:11 — with GitHub Actions Active
@guysopher
guysopher deployed to issue-triage September 25, 2026 11:13 — with GitHub Actions Active
@guysopher
guysopher deployed to issue-triage September 25, 2026 11:13 — with GitHub Actions Active
@guysopher
guysopher deployed to issue-triage September 25, 2026 11:13 — with GitHub Actions Active
@guysopher
guysopher deployed to issue-triage September 25, 2026 11:14 — with GitHub Actions Active
@jamosdev
jamosdev deployed to issue-triage September 25, 2026 11:18 — with GitHub Actions Active
@jamosdev
jamosdev deployed to issue-triage September 25, 2026 11:18 — with GitHub Actions Active
@jamosdev
jamosdev deployed to issue-triage September 25, 2026 11:18 — with GitHub Actions Active
@azazar
azazar deployed to issue-triage September 25, 2026 11:26 — with GitHub Actions Active
@azazar
azazar deployed to issue-triage September 25, 2026 11:26 — with GitHub Actions Active
@azazar
azazar deployed to issue-triage September 25, 2026 11:26 — with GitHub Actions Active
@azazar
azazar deployed to issue-triage September 25, 2026 11:27 — with GitHub Actions Active
@fyodor95
fyodor95 deployed to issue-triage September 25, 2026 11:30 — with GitHub Actions Active
@fyodor95
fyodor95 deployed to issue-triage September 25, 2026 11:30 — with GitHub Actions Active
@fyodor95
fyodor95 deployed to issue-triage September 25, 2026 11:30 — with GitHub Actions Active
@fyodor95
fyodor95 deployed to issue-triage September 25, 2026 11:31 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 86be5320 Deployed Sep 25, 2026 by fyodor95 via Identify potential duplicates (open issues fallback) #48219
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants