Skip to content

Test same-cell permission grants and strict review in code mode - #48017

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/02c958071db4e9ba667be9ba95fbb3a506ae1572
Sep 25, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/02c958071db4e9ba667be9ba95fbb3a506ae1572

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Test same-cell permission grants and strict review in code mode

What changed

Add app-server integration coverage for awaiting request_permissions and then running exec_command in the same code-mode cell:

  • Verify that turn- and session-scoped write grants allow the command to create a file, including grant propagation to Windows command approval requests.
  • Verify that strictAutoReview immediately triggers review for a command needing no additional access and returns the reviewer's denial rationale.

## What changed

Add app-server integration coverage for awaiting `request_permissions` and then running `exec_command` in the same code-mode cell:

- Verify that turn- and session-scoped write grants allow the command to create a file, including grant propagation to Windows command approval requests.
- Verify that `strictAutoReview` immediately triggers review for a command needing no additional access and returns the reviewer's denial rationale.

GitOrigin-RevId: 02c958071db4e9ba667be9ba95fbb3a506ae1572
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/02c958071db4e9ba667be9ba95fbb3a506ae1572 branch from 4131a13 to d7b07d4 Compare September 25, 2026 06:20
@copyberry
copyberry Bot merged commit d7b07d4 into main Sep 25, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/02c958071db4e9ba667be9ba95fbb3a506ae1572 branch September 25, 2026 06:20
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2026
@jlacours
jlacours deployed to issue-triage September 25, 2026 06:23 — with GitHub Actions Active
@jlacours
jlacours deployed to issue-triage September 25, 2026 06:23 — with GitHub Actions Active
@jlacours
jlacours deployed to issue-triage September 25, 2026 06:23 — with GitHub Actions Active
@jlacours
jlacours deployed to issue-triage September 25, 2026 06:24 — with GitHub Actions Active
@spec288
spec288 deployed to issue-triage September 25, 2026 06:56 — with GitHub Actions Active
@spec288
spec288 deployed to issue-triage September 25, 2026 06:56 — with GitHub Actions Active
@spec288
spec288 deployed to issue-triage September 25, 2026 06:56 — with GitHub Actions Active
@tmk04747
tmk04747 deployed to issue-triage September 25, 2026 06:59 — with GitHub Actions Active
@tmk04747
tmk04747 deployed to issue-triage September 25, 2026 06:59 — with GitHub Actions Active
@tmk04747
tmk04747 deployed to issue-triage September 25, 2026 06:59 — with GitHub Actions Active
@tmk04747
tmk04747 deployed to issue-triage September 25, 2026 07:00 — with GitHub Actions Active
@ngaga
ngaga deployed to issue-triage September 25, 2026 07:30 — with GitHub Actions Active
@ngaga
ngaga deployed to issue-triage September 25, 2026 07:30 — with GitHub Actions Active
@ngaga
ngaga deployed to issue-triage September 25, 2026 07:30 — with GitHub Actions Active
@gctwnl
gctwnl deployed to issue-triage September 25, 2026 07:46 — with GitHub Actions Active
@gctwnl
gctwnl deployed to issue-triage September 25, 2026 07:46 — with GitHub Actions Active
@gctwnl
gctwnl deployed to issue-triage September 25, 2026 07:46 — with GitHub Actions Active
@dmzu-cn
dmzu-cn deployed to issue-triage September 25, 2026 07:47 — with GitHub Actions Active
@dmzu-cn
dmzu-cn deployed to issue-triage September 25, 2026 07:47 — with GitHub Actions Active
@dmzu-cn
dmzu-cn deployed to issue-triage September 25, 2026 07:47 — with GitHub Actions Active
@gctwnl
gctwnl deployed to issue-triage September 25, 2026 07:47 — with GitHub Actions Active
@AdamK13
AdamK13 deployed to issue-triage September 25, 2026 08:25 — with GitHub Actions Active
@AdamK13
AdamK13 deployed to issue-triage September 25, 2026 08:25 — with GitHub Actions Active
@AdamK13
AdamK13 deployed to issue-triage September 25, 2026 08:25 — with GitHub Actions Active
@AdamK13
AdamK13 deployed to issue-triage September 25, 2026 08:26 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — d7b07d45 Deployed Sep 25, 2026 by AdamK13 via Identify potential duplicates (open issues fallback) #48173
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.