Avoid nested read locking when rendering browser sign-in - #47861
Merged
copyberry[bot] merged 1 commit intoSep 24, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why `render_ref` already holds a read lock on `sign_in_state`. Acquiring another read lock in `render_continue_in_browser` can deadlock when a writer is waiting. ## What changed Pass the borrowed `ContinueInBrowserState` from `render_ref` into the browser sign-in renderer instead of reading the lock again. ## Testing Update the existing narrow-width browser sign-in test to exercise `render_ref`, retaining checks for the full OSC 8 authentication link, device-code guidance, and cancellation footer. GitOrigin-RevId: ba83e212d510627be9dfd068c8d7318da32a1749
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ba83e212d510627be9dfd068c8d7318da32a1749
branch
from
September 24, 2026 15:21
35e5446 to
3e9d1d2
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ba83e212d510627be9dfd068c8d7318da32a1749
branch
September 24, 2026 15:21
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid nested read locking when rendering browser sign-in
Why
render_refalready holds a read lock onsign_in_state. Acquiring another read lock inrender_continue_in_browsercan deadlock when a writer is waiting.What changed
Pass the borrowed
ContinueInBrowserStatefromrender_refinto the browser sign-in renderer instead of reading the lock again.Testing
Update the existing narrow-width browser sign-in test to exercise
render_ref, retaining checks for the full OSC 8 authentication link, device-code guidance, and cancellation footer.