Repository navigation
Support quoted labels and ampersands in Mermaid flowcharts - #47678
Merged
copyberry[bot] merged 1 commit intoSep 23, 2026
Conversation
## Why Flowcharts with labels such as `A["Review & confirm"]` fell back to source display instead of rendering a diagram. ## What changed Accept double-quoted node and edge labels, strip the surrounding quotes, and allow literal ampersands in flowchart labels. Keep other diagram families' label restrictions and continue rejecting HTML, entity escapes, and malformed quotes. ## Testing Add parser and renderer regression tests for quoted labels, literal ampersands, statement separators, and unsupported text, plus TUI coverage for rendered labels and entity source fallback. GitOrigin-RevId: 9e61a04665f0266d369fa3595411c9a72f10cb9d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/9e61a04665f0266d369fa3595411c9a72f10cb9d
branch
from
September 23, 2026 22:09
4671ac0 to
9477081
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/9e61a04665f0266d369fa3595411c9a72f10cb9d
branch
September 23, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support quoted labels and ampersands in Mermaid flowcharts
Why
Flowcharts with labels such as
A["Review & confirm"]fell back to source display instead of rendering a diagram.What changed
Accept double-quoted node and edge labels, strip the surrounding quotes, and allow literal ampersands in flowchart labels. Keep other diagram families' label restrictions and continue rejecting HTML, entity escapes, and malformed quotes.
Testing
Add parser and renderer regression tests for quoted labels, literal ampersands, statement separators, and unsupported text, plus TUI coverage for rendered labels and entity source fallback.