Repository navigation
Use native POSIX spawning for command hooks - #47610
Merged
copyberry[bot] merged 1 commit intoSep 23, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Unix command hooks use a `pre_exec` callback to detach from the controlling terminal, forcing the launcher to fork. Native spawn attributes can create the detached session without that callback. ## What changed - Route Unix hooks through `codex_utils_pty::Command` with `ProcessMode::NewSession`. - Extend the native `posix_spawn` launcher to detached Linux sessions, retaining compatibility fallbacks for unsupported libc features and executable handling. - Preserve the session environment snapshot, hook overrides, and restricted-variable filtering. ## Testing Add regression coverage for launches without parent forks, terminal detachment, environment and argument handling, Linux `PATH` lookup, and executable compatibility. Cover process-group cleanup on cancellation and timeout, including descendants holding output pipes open, and preservation of background descendants after completed hooks. GitOrigin-RevId: dbe2cf12d84aa79868cfb55ace40c7d5b5282703
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/dbe2cf12d84aa79868cfb55ace40c7d5b5282703
branch
from
September 23, 2026 18:24
5d5ad64 to
7aa6519
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/dbe2cf12d84aa79868cfb55ace40c7d5b5282703
branch
September 23, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use native POSIX spawning for command hooks
Why
Unix command hooks use a
pre_execcallback to detach from the controlling terminal, forcing the launcher to fork. Native spawn attributes can create the detached session without that callback.What changed
codex_utils_pty::CommandwithProcessMode::NewSession.posix_spawnlauncher to detached Linux sessions, retaining compatibility fallbacks for unsupported libc features and executable handling.Testing
Add regression coverage for launches without parent forks, terminal detachment, environment and argument handling, Linux
PATHlookup, and executable compatibility. Cover process-group cleanup on cancellation and timeout, including descendants holding output pipes open, and preservation of background descendants after completed hooks.