Skip to content

Add extra policy configuration for Guardian reviews - #47125

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/180d8d716c63fe96a92ec5bfbd22db4ddccd4f1f
Sep 21, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/180d8d716c63fe96a92ec5bfbd22db4ddccd4f1f

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Add extra policy configuration for Guardian reviews

What changed

  • Add auto_review.extra_policy and the managed guardian_extra_policy requirement to supply policy text alongside the resolved tenant policy. Nonblank managed values take precedence; blank values are ignored.
  • Render the additional text through {{ extra_policy }} in Guardian reviewer templates and append it to the tenant policy for Guardian v2 classification before truncation.
  • Preserve placeholder-like text inside supplied policies literally.

Testing

Add coverage for configuration precedence, blank values, template substitution, and classifier prompts, plus a scenario verifying that managed tenant and extra policies reach the Guardian reviewer together.

## What changed

- Add `auto_review.extra_policy` and the managed `guardian_extra_policy` requirement to supply policy text alongside the resolved tenant policy. Nonblank managed values take precedence; blank values are ignored.
- Render the additional text through `{{ extra_policy }}` in Guardian reviewer templates and append it to the tenant policy for Guardian v2 classification before truncation.
- Preserve placeholder-like text inside supplied policies literally.

## Testing

Add coverage for configuration precedence, blank values, template substitution, and classifier prompts, plus a scenario verifying that managed tenant and extra policies reach the Guardian reviewer together.

GitOrigin-RevId: 180d8d716c63fe96a92ec5bfbd22db4ddccd4f1f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/180d8d716c63fe96a92ec5bfbd22db4ddccd4f1f branch from dd829fe to 26cb4d7 Compare September 21, 2026 23:06
@copyberry
copyberry Bot merged commit 26cb4d7 into main Sep 21, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/180d8d716c63fe96a92ec5bfbd22db4ddccd4f1f branch September 21, 2026 23:06
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 21, 2026
@Mainkill1
Mainkill1 deployed to issue-triage September 21, 2026 23:11 — with GitHub Actions Active
@Mainkill1
Mainkill1 deployed to issue-triage September 21, 2026 23:11 — with GitHub Actions Active
@Mainkill1
Mainkill1 deployed to issue-triage September 21, 2026 23:11 — with GitHub Actions Active
@Mainkill1
Mainkill1 deployed to issue-triage September 21, 2026 23:12 — with GitHub Actions Active
@cjrock1
cjrock1 deployed to issue-triage September 21, 2026 23:20 — with GitHub Actions Active
@cjrock1
cjrock1 deployed to issue-triage September 21, 2026 23:20 — with GitHub Actions Active
@cjrock1
cjrock1 deployed to issue-triage September 21, 2026 23:20 — with GitHub Actions Active
@cjrock1
cjrock1 deployed to issue-triage September 21, 2026 23:21 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
issue-triage — 26cb4d73 Deployed Sep 21, 2026 by cjrock1 via Identify potential duplicates (open issues fallback) #47261
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants