Separate plugin catalog listing from package resolution - #46567
Merged
copyberry[bot] merged 1 commit intoSep 19, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## What changed - Move catalog types and the `PluginProvider` listing interface into `codex-core-plugins`, with a concrete `PluginListQuery` carrying thread, turn, and MCP resource context. - Remove root resolution from `PluginProvider`; keep executor package access in `ExecutorPluginProvider::resolve_bound`, which retains the filesystem used to resolve the package. - Add shared provider result and error types, and re-export the listing API from `codex-mcp-extension`. ## Testing Update executor and manifest tests to use `resolve_bound`, and assert that malformed manifest errors preserve the underlying `serde_json::Error` as their source. GitOrigin-RevId: c6cd5a0269ed3b8ac9b93f306a70821e63e3671e
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/c6cd5a0269ed3b8ac9b93f306a70821e63e3671e
branch
from
September 19, 2026 01:49
62ceffa to
a7e069d
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/c6cd5a0269ed3b8ac9b93f306a70821e63e3671e
branch
September 19, 2026 01:49
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate plugin catalog listing from package resolution
What changed
PluginProviderlisting interface intocodex-core-plugins, with a concretePluginListQuerycarrying thread, turn, and MCP resource context.PluginProvider; keep executor package access inExecutorPluginProvider::resolve_bound, which retains the filesystem used to resolve the package.codex-mcp-extension.Testing
Update executor and manifest tests to use
resolve_bound, and assert that malformed manifest errors preserve the underlyingserde_json::Erroras their source.