Repository navigation
Allow unrelated namespace mounts in Linux sandbox socket checks - #46535
Merged
copyberry[bot] merged 1 commit intoSep 19, 2026
Conversation
## Why Namespace mounts can have roots such as `mnt:[inode]` or `net:[inode]` that are not filesystem paths. Treating every mount root as a path rejects these unrelated mounts and prevents sandbox startup. ## What changed Parse mount roots as paths only for the daemon socket's filesystem. Continue validating every mount destination and checking mount ancestry, nested mounts, and socket aliases. ## Testing Add regression cases for namespace mounts, invalid destinations, and socket aliases, both with and without a mount ID. Extend the socket-isolation integration fixture with an unrelated network namespace mount to exercise successful startup and rejection of a real socket alias. GitOrigin-RevId: 9a1d2a69e5bd3f8d09b1de7cf998ee6d9c6bb980
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/9a1d2a69e5bd3f8d09b1de7cf998ee6d9c6bb980
branch
from
September 19, 2026 00:31
e5857a3 to
22dea11
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/9a1d2a69e5bd3f8d09b1de7cf998ee6d9c6bb980
branch
September 19, 2026 00:31
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow unrelated namespace mounts in Linux sandbox socket checks
Why
Namespace mounts can have roots such as
mnt:[inode]ornet:[inode]that are not filesystem paths. Treating every mount root as a path rejects these unrelated mounts and prevents sandbox startup.What changed
Parse mount roots as paths only for the daemon socket's filesystem. Continue validating every mount destination and checking mount ancestry, nested mounts, and socket aliases.
Testing
Add regression cases for namespace mounts, invalid destinations, and socket aliases, both with and without a mount ID. Extend the socket-isolation integration fixture with an unrelated network namespace mount to exercise successful startup and rejection of a real socket alias.