Default local binding to true for MXC managed networking - #46523
Merged
copyberry[bot] merged 1 commit intoSep 19, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why MXC's native host-loopback access is bidirectional, so it cannot enforce `allow_local_binding = false`. Treating an omitted setting as `false` prevents managed networking from working with the default configuration. ## What changed - Preserve an omitted `allow_local_binding` until the executor's sandbox policy is known. Default to `true` for Windows MXC and `false` elsewhere, including remote execution. - Reject an effective `false` for MXC managed networking after applying policy restrictions, without enabling disabled networking. - Use the executor's resolved value for remote network approval decisions while preserving explicit controller restrictions. - Document that local binding permits local servers and direct host-loopback connections and skips additional private-network destination checks; proxy domain rules still apply. ## Testing Add coverage for per-executor defaults, explicit values, MXC rejection of `false`, and remote network review cleanup with the resolved policy. GitOrigin-RevId: 0fa7c1eaec68bebada2b8f7af45688315eea70a9
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0fa7c1eaec68bebada2b8f7af45688315eea70a9
branch
from
September 19, 2026 00:00
f940b2f to
74af249
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0fa7c1eaec68bebada2b8f7af45688315eea70a9
branch
September 19, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default local binding to true for MXC managed networking
Why
MXC's native host-loopback access is bidirectional, so it cannot enforce
allow_local_binding = false. Treating an omitted setting asfalseprevents managed networking from working with the default configuration.What changed
allow_local_bindinguntil the executor's sandbox policy is known. Default totruefor Windows MXC andfalseelsewhere, including remote execution.falsefor MXC managed networking after applying policy restrictions, without enabling disabled networking.Testing
Add coverage for per-executor defaults, explicit values, MXC rejection of
false, and remote network review cleanup with the resolved policy.