Repository navigation
Bind executor plugin measurements to the trusted plugin version - #46528
Merged
copyberry[bot] merged 1 commit intoSep 19, 2026
Conversation
## Why Identical script contents across plugin versions do not establish that the same measurement declaration applies. Resolving measurements through generic command attribution could use a different version's declaration, while shared helper paths could make attribution ambiguous. ## What changed - Match canonical executor paths against trusted plugin identities before comparing script contents. Require an exact version match for measurements while retaining attribution across versions with matching contents. - Keep measurement declarations bound to the selected trusted root, and allow distinct versions to coexist when extending trusted roots. - Add `PluginMeasurementTarget` to extract an untrusted plugin/version hint from canonical remote cache paths, respecting Windows and POSIX path conventions. - Skip executor lookups for unrelated scripts so attribution does not wait for executor provisioning. - Increase the login unit test timeout in Bazel to `long`. ## Testing Add regression coverage for multiple plugins and versions, canonical aliases, symlink escapes, path casing, and executor lookup avoidance. Add a remote execution integration test verifying that mismatched versions retain command attribution but receive no metrics sidecar, and matching versions use the trusted measurement declaration. GitOrigin-RevId: d63430b37bf2de360c8d09af7f7453a5b5024d72
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d63430b37bf2de360c8d09af7f7453a5b5024d72
branch
from
September 19, 2026 00:14
1bd16da to
6cf2ff1
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d63430b37bf2de360c8d09af7f7453a5b5024d72
branch
September 19, 2026 00:14
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind executor plugin measurements to the trusted plugin version
Why
Identical script contents across plugin versions do not establish that the same measurement declaration applies. Resolving measurements through generic command attribution could use a different version's declaration, while shared helper paths could make attribution ambiguous.
What changed
PluginMeasurementTargetto extract an untrusted plugin/version hint from canonical remote cache paths, respecting Windows and POSIX path conventions.long.Testing
Add regression coverage for multiple plugins and versions, canonical aliases, symlink escapes, path casing, and executor lookup avoidance. Add a remote execution integration test verifying that mismatched versions retain command attribution but receive no metrics sidecar, and matching versions use the trusted measurement declaration.