Avoid cloning turn items for app-server active turn lookups - #46305
Merged
copyberry[bot] merged 1 commit intoSep 17, 2026
Conversation
## Why App-server callers that only need the active turn ID or its presence currently create a full turn snapshot, unnecessarily cloning its items. ## What changed Expose `ThreadState::active_turn_id()` and use it for interrupt validation, elicitation turn ID fallback, and teardown and shutdown logging, preserving the existing turn selection behavior. ## Testing Update the interrupt integration test to wait for `turn/started` instead of a fixed delay and verify that an incorrect turn ID is rejected before successfully interrupting the active turn. GitOrigin-RevId: 4a030655fbc4d229809cf13f80c3d7f788f19c13
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4a030655fbc4d229809cf13f80c3d7f788f19c13
branch
from
September 17, 2026 21:25
a98edfb to
55db7e8
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4a030655fbc4d229809cf13f80c3d7f788f19c13
branch
September 17, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cloning turn items for app-server active turn lookups
Why
App-server callers that only need the active turn ID or its presence currently create a full turn snapshot, unnecessarily cloning its items.
What changed
Expose
ThreadState::active_turn_id()and use it for interrupt validation, elicitation turn ID fallback, and teardown and shutdown logging, preserving the existing turn selection behavior.Testing
Update the interrupt integration test to wait for
turn/startedinstead of a fixed delay and verify that an incorrect turn ID is rejected before successfully interrupting the active turn.