Track WebSocket continuation modes and full-input send reasons - #46051
Merged
copyberry[bot] merged 1 commit intoSep 16, 2026
Conversation
## Why Per-socket metrics label resends after reconnect as initial requests, obscuring why full input was sent. Client telemetry can preserve that reason across reconnect failures and turn boundaries. ## What changed - Add `codex.websocket.continuation` to count `response.create` send attempts, including failed sends, with `mode`, `reason`, and `phase` tags. - Distinguish incremental continuations, fresh requests, restored history, closed connections, and other full-input sends. Track warmup and generation separately. - Preserve the first continuation reset reason until the next send and identify resumed or forked history. - Allow session telemetry to use a `MetricsClient` supplied through thread extensions and document the counter's semantics. ## Testing Add metric assertions for incremental reuse, warmup, changed requests, account switches, reconnects, and resumed or forked history. Add a unit test for preserving reset reasons across repeated resets and turn boundaries. GitOrigin-RevId: 29324f5e9d5677e0c6068f89b2256a92a5a0d157
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/29324f5e9d5677e0c6068f89b2256a92a5a0d157
branch
from
September 16, 2026 22:44
346a65b to
c56dda7
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/29324f5e9d5677e0c6068f89b2256a92a5a0d157
branch
September 16, 2026 22:44
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track WebSocket continuation modes and full-input send reasons
Why
Per-socket metrics label resends after reconnect as initial requests, obscuring why full input was sent. Client telemetry can preserve that reason across reconnect failures and turn boundaries.
What changed
codex.websocket.continuationto countresponse.createsend attempts, including failed sends, withmode,reason, andphasetags.MetricsClientsupplied through thread extensions and document the counter's semantics.Testing
Add metric assertions for incremental reuse, warmup, changed requests, account switches, reconnects, and resumed or forked history. Add a unit test for preserving reset reasons across repeated resets and turn boundaries.