Keep Noise relay streams alive after repeated handshake failures - #46031
Merged
copyberry[bot] merged 1 commit intoSep 16, 2026
Conversation
) ## Why Exhausting the handshake failure budget closed the physical relay, disconnecting authenticated streams along with failed attempts. ## What changed After eight failed handshakes, pause new handshake admission for 10 seconds. Reset incoming handshake attempts before parsing them while existing streams and pending validations continue. Failures during the cooldown do not extend it, and the failure budget resets when handshake admission resumes. ## Testing Update relay tests to cover duplicate handshakes and early data without disconnecting the relay. Verify that encrypted traffic on an established stream continues during cooldown, rejected attempts skip authorization checks, and new handshakes succeed after cooldown expires. GitOrigin-RevId: 0a5098ed1b3c31466f9c091f46cbb20415c7aa1d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0a5098ed1b3c31466f9c091f46cbb20415c7aa1d
branch
from
September 16, 2026 21:21
ebd8c8d to
105fe87
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0a5098ed1b3c31466f9c091f46cbb20415c7aa1d
branch
September 16, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep Noise relay streams alive after repeated handshake failures
Why
Exhausting the handshake failure budget closed the physical relay, disconnecting authenticated streams along with failed attempts.
What changed
After eight failed handshakes, pause new handshake admission for 10 seconds. Reset incoming handshake attempts before parsing them while existing streams and pending validations continue. Failures during the cooldown do not extend it, and the failure budget resets when handshake admission resumes.
Testing
Update relay tests to cover duplicate handshakes and early data without disconnecting the relay. Verify that encrypted traffic on an established stream continues during cooldown, rejected attempts skip authorization checks, and new handshakes succeed after cooldown expires.