Reject paths in project documentation fallback filenames - #45865
Merged
copyberry[bot] merged 1 commit intoSep 16, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Probing Windows network paths can send ambient credentials, even during metadata checks. Entries in `project_doc_fallback_filenames` must be validated before filesystem probes. ## What changed Ignore entries containing path syntax according to the executor's OS, rather than the host's. Reject `.` and `..`, slashes, and NUL characters on all executors; also reject backslashes and colons on Windows. Log a warning for rejected entries and continue considering valid filenames. ## Testing Add tests that verify invalid entries never reach metadata probes under POSIX and Windows path conventions, preserve backslashes and colons in POSIX filenames, and confirm valid fallback instructions still load alongside invalid entries. GitOrigin-RevId: 4369e9b97ae6a3560d09e79efd8c85adac3d1d90
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4369e9b97ae6a3560d09e79efd8c85adac3d1d90
branch
from
September 16, 2026 04:59
70e0b7d to
50d7795
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4369e9b97ae6a3560d09e79efd8c85adac3d1d90
branch
September 16, 2026 04:59
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject paths in project documentation fallback filenames
Why
Probing Windows network paths can send ambient credentials, even during metadata checks. Entries in
project_doc_fallback_filenamesmust be validated before filesystem probes.What changed
Ignore entries containing path syntax according to the executor's OS, rather than the host's. Reject
.and.., slashes, and NUL characters on all executors; also reject backslashes and colons on Windows. Log a warning for rejected entries and continue considering valid filenames.Testing
Add tests that verify invalid entries never reach metadata probes under POSIX and Windows path conventions, preserve backslashes and colons in POSIX filenames, and confirm valid fallback instructions still load alongside invalid entries.