Skip to content

Use app-server state for TUI Windows sandbox decisions - #45821

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d85ac66d18951b752e71d1a6bf25404eeedcad02
Sep 16, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d85ac66d18951b752e71d1a6bf25404eeedcad02

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Use app-server state for TUI Windows sandbox decisions

Why

Windows sandbox setup and permission choices need to reflect the connected app server's requirements and the active thread's executors.

What changed

  • Refresh sandbox configuration and requirements for the current working directory when threads or directories change, before setup, and after setup completes.
  • Use the thread's observed environments to determine whether sandbox setup is local, remote, mixed, or unknown.
  • Defer initial prompt submission while requirements load and preserve the draft if loading fails or required setup is unavailable.
  • Hide sandbox setup choices and elevation commands that requirements or executor selection disallow.

Testing

Add coverage for observed thread hosts, app-server configuration reads, draft preservation and recovery after read failures, deferred initial prompts, and non-admin-only setup choices.

## Why

Windows sandbox setup and permission choices need to reflect the connected app server's requirements and the active thread's executors.

## What changed

- Refresh sandbox configuration and requirements for the current working directory when threads or directories change, before setup, and after setup completes.
- Use the thread's observed environments to determine whether sandbox setup is local, remote, mixed, or unknown.
- Defer initial prompt submission while requirements load and preserve the draft if loading fails or required setup is unavailable.
- Hide sandbox setup choices and elevation commands that requirements or executor selection disallow.

## Testing

Add coverage for observed thread hosts, app-server configuration reads, draft preservation and recovery after read failures, deferred initial prompts, and non-admin-only setup choices.

GitOrigin-RevId: d85ac66d18951b752e71d1a6bf25404eeedcad02
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/d85ac66d18951b752e71d1a6bf25404eeedcad02 branch from 9f6d28c to 73db60e Compare September 16, 2026 01:01
@copyberry
copyberry Bot merged commit 73db60e into main Sep 16, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/d85ac66d18951b752e71d1a6bf25404eeedcad02 branch September 16, 2026 01:01
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant