Repository navigation
Disable V8 optimization paths affected by array sort bugs - #45760
Merged
copyberry[bot] merged 1 commit intoSep 15, 2026
Conversation
## Why The pinned V8 can inline `Array.prototype.sort` with incompatible element kinds when a comparator mutates the array, allowing an object to be stored in an integer-elements array. ## What changed Disable Maglev, Turbolev, and TurboFan array builtin inlining during code-mode runtime initialization until the V8 artifacts include the upstream fix. ## Testing Add an integration regression test that requests top-tier and Maglev optimization, checks element kinds after comparator mutation, and verifies ordinary numeric sorting still returns `[1,2,3]`. GitOrigin-RevId: cea38e920245d6a133a5263118dc664fb3e61838
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/cea38e920245d6a133a5263118dc664fb3e61838
branch
from
September 15, 2026 18:52
5bd88d6 to
aaa2cab
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/cea38e920245d6a133a5263118dc664fb3e61838
branch
September 15, 2026 18:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable V8 optimization paths affected by array sort bugs
Why
The pinned V8 can inline
Array.prototype.sortwith incompatible element kinds when a comparator mutates the array, allowing an object to be stored in an integer-elements array.What changed
Disable Maglev, Turbolev, and TurboFan array builtin inlining during code-mode runtime initialization until the V8 artifacts include the upstream fix.
Testing
Add an integration regression test that requests top-tier and Maglev optimization, checks element kinds after comparator mutation, and verifies ordinary numeric sorting still returns
[1,2,3].