Skip to content

Use captured step settings for request metadata and tool hooks - #45248

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/9dee46a8b4839de8b434cdad4ed441cc0bb6ff9b
Sep 13, 2026
Merged

copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/9dee46a8b4839de8b434cdad4ed441cc0bb6ff9b

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Use captured step settings for request metadata and tool hooks

Why

Model and reasoning effort updates during a turn can leave request metadata and tool hooks reporting the turn's initial settings. Metadata should describe the step that issued the request or tool call.

What changed

  • Share captured execution metadata across Responses, MCP, and extension tool calls, including model, reasoning effort, and automatic review and Node REPL flags.
  • Build Responses tool inventory metadata from the issuing step's finalized tool router. Attach the finalized inventory separately for remote compaction.
  • Use captured step settings for pre- and post-tool hooks, and captured review settings for permission-request hooks.

Testing

Add and extend regression tests for model and effort changes during a turn, MCP metadata, pre-tool hook model attribution, captured review flags, and tool inventory matching the issuing request.

## Why

Model and reasoning effort updates during a turn can leave request metadata and tool hooks reporting the turn's initial settings. Metadata should describe the step that issued the request or tool call.

## What changed

- Share captured execution metadata across Responses, MCP, and extension tool calls, including model, reasoning effort, and automatic review and Node REPL flags.
- Build Responses tool inventory metadata from the issuing step's finalized tool router. Attach the finalized inventory separately for remote compaction.
- Use captured step settings for pre- and post-tool hooks, and captured review settings for permission-request hooks.

## Testing

Add and extend regression tests for model and effort changes during a turn, MCP metadata, pre-tool hook model attribution, captured review flags, and tool inventory matching the issuing request.

GitOrigin-RevId: 9dee46a8b4839de8b434cdad4ed441cc0bb6ff9b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/9dee46a8b4839de8b434cdad4ed441cc0bb6ff9b branch from e644b2f to 16537b2 Compare September 13, 2026 15:48
@copyberry
copyberry Bot merged commit 16537b2 into main Sep 13, 2026
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/9dee46a8b4839de8b434cdad4ed441cc0bb6ff9b branch September 13, 2026 15:48
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 13, 2026

This branch was successfully deployed

1 active deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants