Split Windows sandbox cleanup into preparation and completion phases - #45178
Merged
copyberry[bot] merged 1 commit intoSep 13, 2026
Conversation
…45178) ## What changed Expose `prepare_packaged_windows_sandbox_cleanup` to disable sandbox accounts and stop their processes before returning a `PreparedWindowsSandboxCleanup` guard that retains the setup lock. Its `finish` method removes resources and protections; dropping it only releases the lock, leaving accounts disabled and protections intact. Keep `clean_up_packaged_windows_sandbox` as a wrapper around both phases, and extract the service's existing package cleanup logic into a dedicated module. GitOrigin-RevId: a32663171bce027f771f738d71b0c46404edbedc
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a32663171bce027f771f738d71b0c46404edbedc
branch
from
September 13, 2026 06:15
e93639b to
a4c61af
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a32663171bce027f771f738d71b0c46404edbedc
branch
September 13, 2026 06:15
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split Windows sandbox cleanup into preparation and completion phases
What changed
Expose
prepare_packaged_windows_sandbox_cleanupto disable sandbox accounts and stop their processes before returning aPreparedWindowsSandboxCleanupguard that retains the setup lock. Itsfinishmethod removes resources and protections; dropping it only releases the lock, leaving accounts disabled and protections intact.Keep
clean_up_packaged_windows_sandboxas a wrapper around both phases, and extract the service's existing package cleanup logic into a dedicated module.