Honor thread analytics opt-outs when using shared clients - #44646
Merged
copyberry[bot] merged 1 commit intoSep 10, 2026
Conversation
## Why An enabled shared analytics client could override a thread's explicit opt-out. Delegated threads also emitted initialization events through the parent's client, bypassing the child's analytics setting. ## What changed - Use a disabled analytics client when `config.analytics_enabled` is `Some(false)`, without disabling analytics for sibling threads or overriding a disabled host client. - Emit delegated thread initialization events through the child's analytics client. - Expose the effective analytics state through `CodexThread::analytics_enabled()`. ## Testing Add regression tests for explicit and unset thread settings with enabled, disabled, and absent shared clients, plus delegated child opt-outs with an enabled parent. Update compaction and rollout-budget rollback tests to wait for thread idle after turn completion and fail immediately on rollback errors. GitOrigin-RevId: 547852909af1a6822b95c0bcd2336b0d6bc7aad1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/547852909af1a6822b95c0bcd2336b0d6bc7aad1
branch
from
September 10, 2026 21:31
5d0e821 to
60825b4
Compare
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/547852909af1a6822b95c0bcd2336b0d6bc7aad1
branch
September 10, 2026 21:31
jlindley
temporarily deployed
to
issue-triage
September 10, 2026 21:34 — with 
GitHub Actions
Inactive
jlindley
temporarily deployed
to
issue-triage
September 10, 2026 21:34 — with
GitHub Actions
Inactive
jlindley
temporarily deployed
to
issue-triage
September 10, 2026 21:34 — with
GitHub Actions
Inactive
jlindley
temporarily deployed
to
issue-triage
September 10, 2026 21:35 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor thread analytics opt-outs when using shared clients
Why
An enabled shared analytics client could override a thread's explicit opt-out.
Delegated threads also emitted initialization events through the parent's client,
bypassing the child's analytics setting.
What changed
config.analytics_enabledisSome(false),without disabling analytics for sibling threads or overriding a disabled host client.
CodexThread::analytics_enabled().Testing
Add regression tests for explicit and unset thread settings with enabled, disabled,
and absent shared clients, plus delegated child opt-outs with an enabled parent.
Update compaction and rollout-budget rollback tests to wait for thread idle after
turn completion and fail immediately on rollback errors.