Repository navigation
Add Modal as a supported deployment target with full documentation - #20032
Conversation
🛠 DevTools 🛠
Install mlflow from this PRFor Databricks, use the following command: |
|
@debu-sinha Thank you for the contribution! Could you fix the following issue(s)? ⚠ Invalid PR templateThis PR does not appear to have been filed using the MLflow PR template. Please copy the PR template from here and fill it out. |
|
Hi @B-Step62 and team, This is a documentation-only PR adding mlflow-modal-deploy to the community deployment plugins table. Quick Testing InstructionsIf anyone wants to verify the plugin works: # Install
pip install mlflow-modal-deploy modal
# Configure Modal (one-time setup)
modal token new
# Deploy any MLflow model
mlflow deployments create -t modal -m runs:/<run_id>/model --name test-deployment
# List deployments
mlflow deployments list -t modal
# Get predictions
mlflow deployments predict -t modal --name test-deployment --input-path input.json
# Clean up
mlflow deployments delete -t modal --name test-deploymentOr via Python: from mlflow.deployments import get_deploy_client
client = get_deploy_client("modal")
client.create_deployment(
name="my-model",
model_uri="models:/MyModel/1",
config={"gpu": "T4", "min_containers": 1}
)Key Features
The plugin is published on PyPI and the repo has comprehensive tests. If you're satisfied with the implementation and the docs change looks good, would appreciate a review and merge. Thanks! |
eae729d to
33c70f2
Compare
33c70f2 to
ae53e15
Compare
|
Documentation preview for ef89604 is available at: Changed Pages (3)
More info
|
B-Step62
left a comment
There was a problem hiding this comment.
The content looks good overall. Just added a few comments of minor suggestions and sidebar fix.
There was a problem hiding this comment.
Can we add this page to the sidebar config? https://github.com/mlflow/mlflow/blob/master/docs/sidebarsClassicML.ts#L429
|
|
||
| ### GPU Selection | ||
|
|
||
| Modal supports a wide range of GPU types for different workloads: |
There was a problem hiding this comment.
Is this syntax based on some official Modal APIs? If so, let's add a link to the reference so users can check primary source.
| deploys the model using `modal serve` for local testing: | ||
|
|
||
| ```python | ||
| from mlflow_modal import run_local |
There was a problem hiding this comment.
This is great feature!:)
| #### Install Tools | ||
|
|
||
| Ensure the installation of the following tools: | ||
|
|
There was a problem hiding this comment.
| #### Install Tools | |
| Ensure the installation of the following tools: | |
| #### Install Libraries | |
| Ensure the installation of the following libraries: | |
|
All review comments addressed:
Ready for final review/merge. |
|
Added documentation links for all configuration options below the Configuration Options table:
This provides users with quick access to Modal's official documentation for each configuration category. |
|
@B-Step62 Just following up on this - all your review comments have been addressed and you've already approved. Since this is a docs-only change adding Modal to the community plugins table, would you be able to merge when you get a chance? This completes the deployment story alongside the recently merged scorer integrations (Phoenix #19473, TruLens #19492, Guardrails #20038). Thanks! |
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Add comprehensive documentation for deploying MLflow models to Modal's serverless GPU infrastructure: - Add Modal as a supported deployment target in the deployment overview - Create full documentation page following SageMaker/Kubernetes pattern - Include step-by-step deployment guide, configuration options, advanced usage (GPU selection, batching, workspaces), and troubleshooting - Add Modal logo for the deployment target card The mlflow-modal-deploy plugin enables one-command deployment with auto-scaling, GPU support (T4 to H200), and streaming predictions. Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Replace placeholder image with official Modal wordmark logo from modal.com Signed-off-by: debu-sinha <debusinha2009@gmail.com>
The wordmark had light text that was invisible on white backgrounds. Using just the green M blocks symbol which is visible on any background. Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Black background makes the light green Modal text visible. Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
- Add Modal deployment page to sidebar config (sidebarsClassicML.ts) - Change "Install Tools" to "Install Libraries" per B-Step62's suggestion Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
d6c588d to
8077650
Compare
|
@B-Step62 Just rebased to resolve any conflicts with latest main. This is ready to go whenever you get a chance. |
Signed-off-by: debu-sinha <debusinha2009@gmail.com>
…lflow#20032) Signed-off-by: debu-sinha <debusinha2009@gmail.com>
…20032) Signed-off-by: debu-sinha <debusinha2009@gmail.com>
Related Issues/PRs
modal-labs/modal-client#3893
What changes are proposed in this pull request?
Add Modal as a supported deployment target with comprehensive documentation, elevating it from the community plugins table to a first-class deployment option alongside SageMaker, Azure ML, Kubernetes, etc.
Changes:
/docs/classic-ml/deployment/deploy-model-to-modal/Documentation includes:
Plugin repository: https://github.com/debu-sinha/mlflow-modal-deploy
PyPI: https://pypi.org/project/mlflow-modal-deploy/
How is this PR tested?
Documentation-only change. Verified:
Does this PR require documentation update?
Release Notes
Is this a user-facing change?
Add comprehensive documentation for deploying MLflow models to Modal's serverless GPU infrastructure. The mlflow-modal-deploy plugin enables one-command deployment with auto-scaling, GPU support (T4 to H200), streaming predictions, and dynamic batching.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?