[grpc] do not perform simulate txn on sender if onlyTransactionKind is true - #1136
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 10, 2026 14:31 — with 
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 10, 2026 14:32 — with
GitHub Actions
Inactive
joyqvq
temporarily deployed
to
sui-typescript-aws-kms-test-env
July 10, 2026 14:47 — with
GitHub Actions
Inactive
This was referenced Jul 10, 2026
…hout a sender Disable simulation validation checks when resolving onlyTransactionKind builds on the gRPC and GraphQL clients, and stop leaking the 0x0 resolution sender back into the transaction data. Fixes the seal use-case where a kind-only build references an owned object with no sender set. Also fix graphql-codegen: pin the schema to the committed snapshot instead of fetching main live, and drop the redundant `typescript` plugin (v6 typescript-operations double-emits input types). Regenerated queries.ts. Adds an e2e test across all 3 clients.
hayes-mysten
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
a txKind only build, unlike a txData, has no sender or gas fields. seal lets user build their txn with
onlyTransactionKind: trueand no sender, then send it to key server which fills in the sender before simulateTransactionbut now SuiGrpcClient resolves every build via simulateTransaction, which falls back to a 0x0 sender even for kind-only builds. so the check will always fail if there is an owned object. while a temp workaround is to set a throwaway sender for the txn, but the real fix should be in the sdk so that the check is disabled for kind-only builds.
Test plan
How did you test the new or updated feature?
AI Assistance Notice