Skip to content

Remove Dockerfile mention from flake.nix - #5892

Merged
clason merged 1 commit into
tree-sitter:masterfrom
abeforgit:fix/remove-dockerfile-mention
Aug 30, 2026
Merged

Remove Dockerfile mention from flake.nix#5892
clason merged 1 commit into
tree-sitter:masterfrom
abeforgit:fix/remove-dockerfile-mention

Conversation

@abeforgit

Copy link
Copy Markdown
Contributor

When the Dockerfile was removed in 2452dc7 , it looks like the reference to it in the nix flake was forgotten.

Note: There is a second issue with the build, which is related to NixOS/nixpkgs#524985 and probably just needs a nix flake update, I'll investigate that as well in a separate pr.

I've tested this fix by building the package in my nixos configuration, using the following input configuration, with a just-updated lockfile:

My nixpkgs is also on nixpkgs-unstable.

    tree-sitter = {
      url = "github:abeforgit/tree-sitter/fix/remove-dockerfile-mention";
      inputs.nixpkgs.follows = "nixpkgs";
    };

fixes: #5891

AI Policy

  • I have read the AI Policy and this PR complies with it.
  • If AI tools were used: I have disclosed the tool and extent of usage below.

no AI was used

@abeforgit abeforgit changed the title Fix/remove dockerfile mention Remove Dockerfile mention from flake.nix Aug 27, 2026
@clason

clason commented Aug 27, 2026

Copy link
Copy Markdown
Member

Thank you, but the solution here is to remove the flake as well.

@clason clason closed this Aug 27, 2026
@clason clason reopened this Aug 30, 2026
@clason
clason enabled auto-merge (squash) August 30, 2026 16:44
@clason clason added this to the 0.27 milestone Aug 30, 2026
@clason clason added the ci:check release Conduct a dry run of the rust release workflow. label Aug 30, 2026
@clason

clason commented Aug 30, 2026

Copy link
Copy Markdown
Member

After some internal discussion, we're going to merge the fix (and keep the flake) for 0.27 but will remove the files for 0.28. Any further updates (flake update) will have to be done locally, I'm afraid.

@clason
clason merged commit 6070dbf into tree-sitter:master Aug 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:check release Conduct a dry run of the rust release workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix build fails due to missing Dockerfile

2 participants