Skip to content

[Screenshot] Show preview image and download button when creating a screenshot #57937

Description

@rebron

Description

Using the screenshot tool for selection, visible area, or full page takes you immediately to the Save dialog. We should show a preview image with the screenshot and a download button.

When using the keyboard shortcut Shift+Command+S to do a selection style screenshot, a preview dialog does appear. That same flow should happen when using the screenshot button.

Steps to reproduce

  1. Use 1.94.x and higher
  2. Go to brave://settings/appearance toolbar panel and enable the screenshot button
  3. Take a screenshot. Notice the save dialog appears after taking a screenshot.

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.94.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions