Repository navigation
fix: add Floorp Browser support - #683
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 192da33 in 33 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/queries.ts:297
- Draft comment:
Good addition for Floorp support. Ensure that the string patterns (e.g. 'Floorp', 'floorp', etc.) and substring matching in browsersWithBuckets (using _.includes) won’t cause false positives. Consider adding tests if not already present. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Xw1MtXXOEYmqOtrH
You can customize 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 26.30% 26.30%
=======================================
Files 29 29
Lines 1684 1684
Branches 288 296 +8
=======================================
Hits 443 443
+ Misses 1219 1180 -39
- Partials 22 61 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add Floorp browser support by updating
browser_appnamesinqueries.ts.floorpinbrowser_appnamesinqueries.ts. RecognizesFloorp,floorp.exe,floorp, andone.ablaze.floorp.This description was created by
for 192da33. You can customize this summary. It will automatically update as commits are pushed.